win: enable delay-load hook by default #708
Conversation
Enables the following commit by default: 52ceec3 See also: nodejs/node@3bda6cb
|
this is one for @nodejs/platform-windows, specifically @piscisaureus who introduced it. I think this is more for io.js than node so maybe not as urgent? |
@othiym23 seemed to think it also applied to electron and nw.js. If it needs to be in a major I'd prefer to get it into npm@3. |
|
@Fishrock123 let's merge this and float on v4 |
|
so, I know we're in a transition phase here and still wanting to defer to @TooTallNate somewhat but I'm also assuming that he's happy for us to take the incentive to get stuff done, so I've gone ahead and merged this and used the core style of merging including adding metadata, I've also added a |
Enables the following commit by default: 52ceec3 See also: nodejs/node@3bda6cb PR-URL: #708 Reviewed-By: Rod Vagg <rod@vagg.org>
|
👍 Feel free to push to master. I've also added @rvagg and @Fishrock123 as owners on the npm package. Cheers! |
Enables the following commit by default:
52ceec3
See also:
nodejs/node@3bda6cb
Seeing if we can get this in, even into a major, to land in npm, so that we don't need to keep patching it in io.js/node.
I talked with @othiym23 a bit last Friday and he seemed to think it wasn't major-worthy. In io.js we wated to do it in a major.
@TooTallNate what are your thoughts on this?
cc @nodejs/tsc?